[fix] Update migration Revision for #6945#7258
Merged
graceguo-supercat merged 1 commit intoapache:masterfrom Apr 10, 2019
Merged
[fix] Update migration Revision for #6945#7258graceguo-supercat merged 1 commit intoapache:masterfrom
graceguo-supercat merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7258 +/- ##
=======================================
Coverage 64.72% 64.72%
=======================================
Files 425 425
Lines 20672 20672
Branches 2282 2282
=======================================
Hits 13380 13380
Misses 7167 7167
Partials 125 125Continue to review full report at Codecov.
|
john-bodley
reviewed
Apr 10, 2019
| # revision identifiers, used by Alembic. | ||
| revision = '80669c0097a6' | ||
| down_revision = 'c82ee8a39623' | ||
| revision = '80aa3f04bc82' |
Member
There was a problem hiding this comment.
I think you should keep the revision ID unchanged.
Author
There was a problem hiding this comment.
after rebase, I created script from scratch, so the system generated new file name.
john-bodley
approved these changes
Apr 10, 2019
Author
|
thanks! i will test in local environment right after merge. |
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
db migration in #6945 was based on an older head. I run
superset db merge headsto make it compatible with master, but when we runsuperset db upgrade, somehow downgrade script from #6945 is not triggered.Solution:
Now I rebased migration script to latest master to make sure revision is from latest master. So downgrade script will be executed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
run
superset db upgradeshould see extra parents attribute in layout meta data.run
superset db downgradeshould see parents attribute are removed.ADDITIONAL INFORMATION
REVIEWERS
@michellethomas @john-bodley